(WIP) KAFKA-18616; Refactor Tools's ApiMessageFormatter #18695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajac
added
the
do-not-merge
|
@chia7712 What do you think about doing something like this? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - This is an attempt to refactor the ApiMessageFormatter to follow what we have done in #18688. The main difference with the current implementation is that unknown versions of values are still deserialized on a best effort basis. The result depends on the schema. This makes me wonder whether we should strengthen the version validation in the CoordinatorRecordSerdes.
Committer Checklist (excluded from commit message)