[WIP]KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors #18548
+78
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
m1a2st
changed the title
|
Hello @lianetm, I will test in this PR |
|
@m1a2st—is there a summary of the issue that caused the previous fix to be reverted? Thanks! |
|
Sorry, I still can't reproduce which test fail in my local machine :( |
m1a2st
commented
Jan 21, 2025
| private void maybePropagateCoordinatorFatalErrorEvent() { | ||
| coordinatorRequestManager.fatalError() | ||
| .ifPresent(fatalError -> backgroundEventHandler.add(new ErrorEvent(fatalError))); | ||
| coordinatorRequestManager.clearFatalError(); |
There was a problem hiding this comment.
ack, I'll take a closer look too asap. In the meantime I re-triggered the build so we can keep validating it.
|
@m1a2st could you solve the conflicts? Also, just to double check, the missing bit was clearing the fatal error after propagating it to the app thread, no other changes? Thanks! |
# Conflicts: # core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-18034
Committer Checklist (excluded from commit message)