Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18206: EmbeddedKafkaCluster must set features #18189

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

brandboat
Copy link
Member

@brandboat brandboat commented Dec 15, 2024

related to KAFKA-18206, set features in EmbeddedKafkaCluster in both streams and connect module, note that this PR also fix potential transaction with empty records in sendPrivileged method as transaction version 2 doesn't allow this kind of scenario.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added tests Test fixes (including flaky tests) small Small PRs labels Dec 15, 2024
@brandboat brandboat marked this pull request as draft December 15, 2024 03:27
@brandboat brandboat marked this pull request as ready for review December 27, 2024 15:20
@mjsax
Copy link
Member

mjsax commented Jan 11, 2025

note that this PR also fix potential transaction with empty records in sendPrivileged method as transaction version 2 doesn't allow this kind of scenario.

Should we split this into it's own PR?

@brandboat
Copy link
Member Author

Should we split this into it's own PR?

Hi @mjsax, sorry I forgot to mention that this was handling in a different issue, here is the PR: #18448

@jolshan
Copy link
Member

jolshan commented Jan 15, 2025

We have merged 18448 so we should be able to proceed here :)

@brandboat
Copy link
Member Author

brandboat commented Jan 16, 2025

I'm not sure why, but it seems like a lot of tests have become more flaky than before in this PR. One failed test in CI (https://github.com/apache/kafka/actions/runs/12810813472) caught my attention: MirrorConnectorsIntegrationTransactionsTest #testOffsetTranslationBehindReplicationFlow. The error message is:

java.lang.RuntimeException: java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.InvalidTxnStateException: The producer attempted a transactional operation in an invalid state.

I expected this failed test should to be mitigated after merging PR #18448, so I'll spend some time investigating this.

@brandboat brandboat changed the title [DO NOT MERGE] KAFKA-18206: EmbeddedKafkaCluster must set features KAFKA-18206: EmbeddedKafkaCluster must set features Jan 20, 2025
@brandboat
Copy link
Member Author

This #18189 (comment) seems due to TV_2 return incorrect error, and should be handled correctly in #18604.

@jolshan
Copy link
Member

jolshan commented Jan 22, 2025

@brandboat I just merged my PR and will restart the tests here. You may need to rebase, but we can try as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants