-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-18206: EmbeddedKafkaCluster must set features #18189
base: trunk
Are you sure you want to change the base?
Conversation
b61db67
to
33ea277
Compare
33ea277
to
17a262f
Compare
17a262f
to
b1982e5
Compare
Should we split this into it's own PR? |
We have merged 18448 so we should be able to proceed here :) |
I'm not sure why, but it seems like a lot of tests have become more flaky than before in this PR. One failed test in CI (https://github.com/apache/kafka/actions/runs/12810813472) caught my attention: MirrorConnectorsIntegrationTransactionsTest #testOffsetTranslationBehindReplicationFlow. The error message is:
I expected this failed test should to be mitigated after merging PR #18448, so I'll spend some time investigating this. |
This #18189 (comment) seems due to TV_2 return incorrect error, and should be handled correctly in #18604. |
@brandboat I just merged my PR and will restart the tests here. You may need to rebase, but we can try as is for now. |
related to KAFKA-18206, set features in EmbeddedKafkaCluster in both streams and connect module, note that this PR also fix potential transaction with empty records in sendPrivileged method as transaction version 2 doesn't allow this kind of scenario.
Committer Checklist (excluded from commit message)