Kafka-16540: Update partitions if min isr config is changed. #18148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
cmccabe
reviewed
Jan 10, 2025
metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java
Outdated
Show resolved
Hide resolved
cmccabe
reviewed
Jan 10, 2025
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java
Outdated
Show resolved
Hide resolved
cmccabe
reviewed
Jan 22, 2025
| @@ -1558,12 +1562,12 @@ private QuorumController( | |||
| setLogContext(logContext). | |||
| setSnapshotRegistry(snapshotRegistry). | |||
| setKafkaConfigSchema(configSchema). | |||
| setFeatureControl(featureControl). | |||
| setExistenceChecker(resourceExists). | |||
| setAlterConfigPolicy(alterConfigPolicy). | |||
| setValidator(configurationValidator). | |||
There was a problem hiding this comment.
I guess this doesn't need to be changed :)
Can leave the setFeatureControl on the line it was previously :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-16540
If the min isr config is changed, we need to update the partitions with ELR if possible.