KAFKA-18058: Share group state record pruning impl. #18014
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.kafka.coordinator.share; | ||
|
|
||
| import org.apache.kafka.server.share.SharePartitionKey; | ||
|
|
||
| import java.util.Comparator; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import java.util.PriorityQueue; | ||
| import java.util.Queue; | ||
| import java.util.concurrent.atomic.AtomicLong; | ||
|
|
||
| public class ShareCoordinatorOffsetsManager { | ||
| private enum State { | ||
| ACTIVE, | ||
| INACTIVE | ||
| } | ||
|
|
||
| static class Entry { | ||
| private final SharePartitionKey key; | ||
| private final long offset; | ||
| private State state; | ||
|
|
||
| private Entry(SharePartitionKey key, long offset) { | ||
| this.key = key; | ||
| this.offset = offset; | ||
| this.state = State.ACTIVE; | ||
| } | ||
|
|
||
| public SharePartitionKey key() { | ||
| return key; | ||
| } | ||
|
|
||
| public long offset() { | ||
| return offset; | ||
| } | ||
|
|
||
| public State state() { | ||
| return state; | ||
| } | ||
|
|
||
| public void setState(State state) { | ||
| this.state = state; | ||
| } | ||
|
|
||
| public static Entry instance(SharePartitionKey key, long offset) { | ||
| return new Entry(key, offset); | ||
| } | ||
| } | ||
|
|
||
| private final Map<SharePartitionKey, Entry> entries = new HashMap<>(); | ||
| private final Queue<Entry> curState; | ||
| private long minOffset = Long.MAX_VALUE; | ||
| private final AtomicLong lastRedundantOffset = new AtomicLong(0); | ||
|
|
||
| public ShareCoordinatorOffsetsManager() { | ||
| curState = new PriorityQueue<>(new Comparator<Entry>() { | ||
| @Override | ||
| public int compare(Entry o1, Entry o2) { | ||
| return Long.compare(o1.offset, o2.offset); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| public Optional<Long> updateState(SharePartitionKey key, long offset) { | ||
| minOffset = Math.min(minOffset, offset); | ||
| if (entries.containsKey(key)) { | ||
| entries.get(key).setState(State.INACTIVE); | ||
| } | ||
| Entry newEntry = Entry.instance(key, offset); | ||
| curState.add(newEntry); | ||
| entries.put(key, newEntry); | ||
|
|
||
| purge(); | ||
|
|
||
| Optional<Long> deleteTillOpt = findLastRedundantOffset(); | ||
| deleteTillOpt.ifPresent(off -> minOffset = off); | ||
| return deleteTillOpt; | ||
| } | ||
|
|
||
| private Optional<Long> findLastRedundantOffset() { | ||
| if (curState.isEmpty()) { | ||
| return Optional.empty(); | ||
| } | ||
|
|
||
| Entry candidate = curState.peek(); | ||
| if (candidate == null) { | ||
| return Optional.empty(); | ||
| } | ||
|
|
||
| if (candidate.offset() <= 0 || candidate.offset() == minOffset) { | ||
| return Optional.empty(); | ||
| } | ||
| lastRedundantOffset.set(candidate.offset()); | ||
| return Optional.of(candidate.offset()); | ||
| } | ||
|
|
||
| public Optional<Long> lastRedundantOffset() { | ||
|
There was a problem hiding this comment. This method is ok, but is very customized for the usage in the current only caller. If there is another caller, it can unexpectedly break the existing caller. A better api is probably to always expose the lastRedundantOffset and let the caller handle the case when the same value is returned. |
||
| return Optional.of(lastRedundantOffset.get()); | ||
| } | ||
|
|
||
| // test visibility | ||
| void purge() { | ||
| while (!curState.isEmpty() && curState.peek().state() == State.INACTIVE) { | ||
| curState.poll(); | ||
| } | ||
| } | ||
|
|
||
| //test visibility | ||
| Queue<Entry> curState() { | ||
| return curState; | ||
| } | ||
|
|
||
| //test visibility | ||
| Map<SharePartitionKey, Entry> entries() { | ||
| return entries; | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this is the wrong approach because it will allow users of the cluster to delete too. When I suggested it, I thought that we would add a boolean to the method, e.g. allowInternalTopics, and use it from the component doing the deletion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, will rectify