GH-2795: Fix race condition in datatype registration #2796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #2795
Pull request Description:
Fixed a race condition in user-defined datatype registration. This change only touches the user-friendly
getSafeTypeByName
and does not change anything from the user's perspective (other than fixing the race condition). TheregisterDatatype
method is left as-is, to allow for overriding datatype registrations if someone really wants to.I've added some notes to
registerDatatype
andunregisterDatatype
that it they have good "shoot-yourself-in-the-foot-with-a-bazooka" potential.By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.