Warnings lucene #2782
Open
Warnings lucene #2782
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
approved these changes
Oct 17, 2024
afs
reviewed
Oct 17, 2024
.github/workflows/maven.yml
Outdated
| @@ -24,10 +24,10 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - name: Set up JDK 17 | |||
| - name: Set up JDK 21 | |||
There was a problem hiding this comment.
How about a new maven-java21.yml?
Jena requires java17 and I think we ought to keep maven.yml at that level.
There was a problem hiding this comment.
What about using matrix for the java versions? https://github.com/OyvindLGjesdal/jena/actions/runs/11392396970
OyvindLGjesdal
force-pushed
the
warnings-lucene
branch
from
f54987a
to
ce8edcd
Compare
OyvindLGjesdal
force-pushed
the
warnings-lucene
branch
from
da1cf6e
to
f675b18
Compare
…ings during tests
OyvindLGjesdal
force-pushed
the
warnings-lucene
branch
from
f675b18
to
925d169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #2533
Pull request Description:
Add different build arguments based on the running JVM version to minimize lucene warnings during build
This is based on how tests are being run in Apache Lucene (in gradle) where they check for java version and add args if >=21
but translated-ish to maven.
https://github.com/apache/lucene/blob/1faf33a02afd610c90ffa8685b1675f9d1c24b0e/gradle/testing/defaults-tests.gradle#L131
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.