-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings lucene #2782
base: main
Are you sure you want to change the base?
Warnings lucene #2782
Conversation
.github/workflows/maven.yml
Outdated
@@ -24,10 +24,10 @@ jobs: | |||
|
|||
steps: | |||
- uses: actions/checkout@v4 | |||
- name: Set up JDK 17 | |||
- name: Set up JDK 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a new maven-java21.yml
?
Jena requires java17 and I think we ought to keep maven.yml
at that level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using matrix for the java versions? https://github.com/OyvindLGjesdal/jena/actions/runs/11392396970
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea
f54987a
to
ce8edcd
Compare
da1cf6e
to
f675b18
Compare
…ings during tests
f675b18
to
925d169
Compare
GitHub issue resolved #2533
Pull request Description:
Add different build arguments based on the running JVM version to minimize lucene warnings during build
This is based on how tests are being run in Apache Lucene (in gradle) where they check for java version and add args if >=21
but translated-ish to maven.
https://github.com/apache/lucene/blob/1faf33a02afd610c90ffa8685b1675f9d1c24b0e/gradle/testing/defaults-tests.gradle#L131
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.