JAMES-4100 Improve Search Snippet display

[hungphan227]

No description provided.

[Arsnael]

Read it, nothing to add

[quantranhong1999]

Lucene tests failed: https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2583/1/testReport/

[Arsnael]

https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2583/1/testReport/

Related I believe

[chibenwa]

Have you tried

StringUtils.remove(s, '>);

Or

CharMatcher.is('>').removeFrom(s)

?

[hungphan227]

Have you tried

StringUtils.remove(s, '>);

Or

CharMatcher.is('>').removeFrom(s)

?

Don't you want to keep at least one character after removing?

[chibenwa]

I do not know: how would it look like in the end user display?

[hungphan227]

I do not know: how would it look like in the end user display?

Example:
Input: >>>>>>>>>> append contentA to >>> inbox >>>>>>
Result: > append contentA to > inbox >

(contentA is the highlighted part)

[chibenwa]

I wonder if append contentA to INBOX wouldn't be better...

[hungphan227]

I wonder if append contentA to INBOX wouldn't be better...

The solution for this is not just StringUtils.remove(s, '>);. We should not remove > from <mark> tag of search snippet.

[Arsnael]

@hungphan227 Status of this?

Tests still not fixed I believe => https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2583/1/testReport/

[hungphan227]

Actually I don't know what I should do.

Either removing all > or keeping just one >, there is no way to make it simple like StringUtils.remove(s, '>);. I know only two ways: either using regex or a loop to iterate through the string.

Therefore, I suggest closing this ticket and leave things as before. Anyway removing > is not really important.

[Arsnael]

Anyway removing > is not really important.

An end user might disagree with you on that I think :)

Honestly I get that removing entirely the trailings > is tricky and might require a non efficient process as you need to be careful with initial > potentially present in the message (and you don't want to break the <mark> tags)

I would be ok with the initial solution, aka folding >>>>> into > but need to fix current breaking related tests.

@chibenwa what are your thoughts here?

[chibenwa]

Ok

[Arsnael]

LGTM but did you try to run locally related tests though? Would be surprised that everything is green :)

[hungphan227]

LGTM but did you try to run locally related tests though? Would be surprised that everything is green :)

Fixed in mailbox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/LuceneSearchHighlighter.java

Sth wrong with CI. Need to restart CI

[Arsnael]

Sth wrong with CI. Need to restart CI

=> #2599 is what's wrong with the CI :)

[chibenwa]

Can we have a look at how it looks like with the frontend?

[hungphan227]

Updated to remove before indexing

[hungphan227]

03:21:52,863 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.6.0:process (default) on project apache-mailet-ai: Execution default of goal org.apache.maven.plugins:maven-remote-resources-plugin:1.6.0:process failed: Could not acquire lock(s)

@Arsnael could you help me restart?

[Arsnael]

https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2583/8/testReport/

Related