Added conditional compilation for musl targets #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. I think this can be documented somewhere so that other people may also interested. @dingelish, what do you think. |
|
sgtm :-) better if comes along with some description by either code comments or readme. |
|
Thanks! Let me add some documentation in a second commit. |
volcano0dr
requested changes
Oct 19, 2020
| fd: c_int, | ||
| request: c_int) -> c_int { | ||
| let mut errno = 0; | ||
| let ret = unsafe { libc::ioctl(fd, request) }; |
There was a problem hiding this comment.
I suggest adding conditional compilation option in this line (let ret = unsafe { libc::ioctl(fd, request) }). Because the function prototype has not changed, I think there is no need to define a function for the musl target separately.
|
@mjquinlan Thank you so much! I'm wondering if there's any update on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows building statically linked applications. This is useful for organizations needing to extend backwards compatibility to older OS releases.