-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize:Expose some keepalive-related configuration for Druid, Hikari, and DBCP #7130
base: 2.x
Are you sure you want to change the base?
Conversation
@@ -194,6 +194,22 @@ seata: | |||
vgroup-table: vgroup_table | |||
query-limit: 1000 | |||
max-wait: 5000 | |||
druid: | |||
timeBetweenEvictionRunsMillis: 120000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, YAML files commonly use lowercase letters and hyphens to separate different words. This is the recommended Kebab Case
style for Spring configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, YAML files commonly use lowercase letters and hyphens to separate different words. This is the recommended
Kebab Case
style for Spring configurations.
Yes.I will correct it.
Ⅰ. Describe what this PR did
Expose some keepalive-related configuration for Druid, Hikari, and DBCP to allow users to customize database connection pool settings.
Ⅱ. Does this pull request fix one issue?
Fixes #6600
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews