Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7750][VL]: store unsafe batches data #7902

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Zand100
Copy link
Contributor

@Zand100 Zand100 commented Nov 12, 2024

What changes were proposed in this pull request?

Adds a binary container implementing a Spark MemoryConsumer to be used instead of Array[Array[Bytes]].

(Fixes: #7750)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions github-actions bot added the VELOX label Nov 12, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@Zand100 Zand100 changed the title store unsafe batches data [GLUTEN-7750][VL]: store unsafe batches data Nov 12, 2024
Copy link

#7750

val recordLength = 2L * uaoSize + inputLength + 8L

UnsafeAlignedOffset.putSize(base, offset, inputLength + uaoSize)
offset += 2L * uaoSize
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I'm calculating the offset correctly

@zhztheplayer
Copy link
Member

@Zand100 Is there any test case can be added for this change?

Comment on lines +68 to +70
val columnVector = new OffHeapColumnVector(batch.numElements(), DataTypes.BinaryType)
columnVector.putByteArray(batchId, batch.toByteArray, batch.getBaseOffset.toInt, batch.numElements)
val columnarBatch = new ColumnarBatch(Array(columnVector))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhztheplayer Is it alright to create the ColumnarBatch this way, using OffHeapColumnVector and constructing a new ColumnarBatch directly from that?

@Zand100
Copy link
Contributor Author

Zand100 commented Nov 13, 2024

I'm planning to write unit and integration tests. I'm still getting familiar with the code. I'm guessing for UnsafeArray, I'll write tests similar to https://github.com/apache/spark/blob/master/core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java. Could you please point me to some other places to update tests? (I couldn't find the tests forColumnarBuildSideRelation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Move ColumnarBuildSideRelation's memory occupation to Spark off-heap
2 participants