Add config to support viewfs in Gluten. #7892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI on x86 |
|
@JkSelf can you add some desc why the PR revert view fs? |
JkSelf
force-pushed
the
revert-viewfs-support
branch
from
0d2ae6a
to
280d490
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
JkSelf
force-pushed
the
revert-viewfs-support
branch
from
907cf70
to
aba91e9
Compare
|
Run Gluten Clickhouse CI on x86 |
JkSelf
force-pushed
the
revert-viewfs-support
branch
from
aba91e9
to
69c9384
Compare
|
Run Gluten Clickhouse CI on x86 |
JkSelf
force-pushed
the
revert-viewfs-support
branch
from
69c9384
to
f936353
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
JkSelf
force-pushed
the
revert-viewfs-support
branch
from
38cb901
to
c39a0ad
Compare
|
Run Gluten Clickhouse CI on x86 |
JkSelf
changed the title
JkSelf
force-pushed
the
revert-viewfs-support
branch
from
c39a0ad
to
4c9e1fd
Compare
|
Run Gluten Clickhouse CI on x86 |
PHILO-HE
approved these changes
Nov 15, 2024
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
Outdated
Show resolved
Hide resolved
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala
Outdated
Show resolved
Hide resolved
|
Run Gluten Clickhouse CI on x86 |
|
@PHILO-HE Thanks for your review. Resolved all your comments. Can you help to approve again? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To enable support for ViewFS in Gluten, we need to call FileSystem.get(viewPath.toUri, serializableHadoopConf.value) to convert the ViewFS path to an HDFS path. Prior to this PR, we passed serializableHadoopConf in getSplitInfosFromPartitions for the conversion. This PR updates the path values after obtaining the LocalFilesNode, thereby reducing the number of times serializableHadoopConf needs to be passed. With this PR, Jenkins performance can improve by about 5%.
How was this patch tested?
Jenkins test