Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6980][CORE] In shim poms, use Scala Maven compiler configuration inherited from parent pom #6972

Merged
merged 11 commits into from
Aug 22, 2024

Conversation

zhztheplayer
Copy link
Member

This could fix build errors Intellij Idea IDE when scala-2.13 profile and spark-3.2/spark-3.3/spark-3.4 profiles are toggled on at the same time.

And with essential code cleanups.

@github-actions github-actions bot added the CORE works for Gluten Core label Aug 22, 2024
Copy link

Run Gluten Clickhouse CI

@apache apache deleted a comment from github-actions bot Aug 22, 2024
Copy link

Run Gluten Clickhouse CI

2 similar comments
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title [CORE] In shim poms, use Scala Maven compiler configuration inherited from parent pom [GLUTEN-6980][CORE] In shim poms, use Scala Maven compiler configuration inherited from parent pom Aug 22, 2024
Copy link

#6980

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhouyuan zhouyuan merged commit d12bf1f into apache:main Aug 22, 2024
44 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_08_22_2024_time.csv log/native_master_08_21_2024_fbd066a8e6_time.csv difference percentage
q1 14.71 14.05 -0.653 95.56%
q2 14.38 14.33 -0.050 99.65%
q3 4.30 4.31 0.005 100.11%
q4 72.04 72.54 0.503 100.70%
q5 7.67 9.57 1.906 124.86%
q6 3.85 2.49 -1.361 64.70%
q7 4.98 6.91 1.926 138.64%
q8 3.36 3.45 0.090 102.67%
q9 23.94 23.67 -0.264 98.90%
q10 9.88 10.06 0.176 101.79%
q11 38.30 38.49 0.195 100.51%
q12 1.36 1.36 0.005 100.39%
q13 6.48 6.57 0.094 101.45%
q14a 45.84 45.87 0.025 100.05%
q14b 43.62 42.04 -1.574 96.39%
q15 2.51 2.30 -0.208 91.70%
q16 46.14 46.53 0.385 100.83%
q17 5.04 4.98 -0.053 98.95%
q18 7.01 6.82 -0.182 97.40%
q19 2.27 3.54 1.278 156.39%
q20 1.57 1.60 0.025 101.62%
q21 1.19 1.04 -0.141 88.09%
q22 7.68 7.68 0.002 100.02%
q23a 104.47 105.71 1.245 101.19%
q23b 129.89 128.97 -0.916 99.30%
q24a 103.08 113.15 10.076 109.78%
q24b 104.81 111.98 7.174 106.84%
q25 4.19 4.11 -0.078 98.13%
q26 2.99 3.14 0.148 104.94%
q27 3.85 6.99 3.146 181.76%
q28 32.66 30.50 -2.164 93.38%
q29 12.07 9.37 -2.697 77.65%
q30 6.53 5.14 -1.392 78.68%
q31 7.51 7.57 0.061 100.82%
q32 1.33 1.47 0.138 110.36%
q33 4.65 4.39 -0.251 94.59%
q34 4.18 4.12 -0.059 98.60%
q35 9.25 7.73 -1.525 83.51%
q36 5.00 4.64 -0.356 92.87%
q37 4.90 4.63 -0.274 94.41%
q38 14.61 13.69 -0.920 93.70%
q39a 3.49 3.09 -0.398 88.61%
q39b 2.80 2.98 0.186 106.64%
q40 3.89 3.73 -0.158 95.95%
q41 0.59 0.72 0.126 121.35%
q42 0.89 0.96 0.073 108.20%
q43 4.83 4.60 -0.236 95.12%
q44 10.00 9.34 -0.662 93.38%
q45 3.36 3.26 -0.101 96.98%
q46 3.77 3.79 0.023 100.60%
q47 19.10 18.67 -0.432 97.74%
q48 5.39 5.23 -0.167 96.90%
q49 8.54 9.24 0.700 108.20%
q50 21.39 21.69 0.296 101.38%
q51 9.99 10.12 0.124 101.24%
q52 1.12 1.12 0.002 100.14%
q53 2.50 2.39 -0.113 95.49%
q54 4.09 3.84 -0.244 94.03%
q55 1.08 1.20 0.127 111.79%
q56 4.08 4.16 0.074 101.81%
q57 10.87 10.92 0.053 100.48%
q58 2.35 3.12 0.769 132.68%
q59 11.46 11.01 -0.442 96.14%
q60 4.18 4.05 -0.129 96.91%
q61 4.08 3.99 -0.094 97.69%
q62 5.17 4.54 -0.631 87.80%
q63 2.45 2.32 -0.127 94.80%
q64 61.41 59.69 -1.718 97.20%
q65 18.63 17.20 -1.429 92.33%
q66 4.33 3.93 -0.408 90.58%
q67 380.50 390.83 10.336 102.72%
q68 3.53 3.74 0.208 105.90%
q69 5.18 5.42 0.237 104.58%
q70 11.74 13.04 1.301 111.09%
q71 2.36 2.38 0.023 100.99%
q72 213.17 214.73 1.555 100.73%
q73 2.25 2.20 -0.059 97.39%
q74 23.93 23.22 -0.713 97.02%
q75 26.72 27.08 0.363 101.36%
q76 11.39 12.48 1.089 109.56%
q77 2.29 2.26 -0.028 98.76%
q78 49.72 50.04 0.322 100.65%
q79 3.91 3.95 0.042 101.08%
q80 12.54 12.38 -0.168 98.66%
q81 4.95 4.84 -0.106 97.85%
q82 7.96 7.13 -0.827 89.61%
q83 1.79 1.71 -0.086 95.19%
q84 2.87 2.75 -0.123 95.72%
q85 8.16 7.16 -1.007 87.67%
q86 4.36 3.98 -0.379 91.30%
q87 13.71 13.39 -0.314 97.71%
q88 21.67 21.39 -0.281 98.70%
q89 3.64 3.56 -0.082 97.75%
q90 3.09 3.33 0.236 107.63%
q91 2.43 2.01 -0.418 82.82%
q92 1.34 1.34 0.006 100.43%
q93 38.66 41.13 2.468 106.38%
q94 25.33 25.33 0.003 100.01%
q9 87.36 88.76 1.399 101.60%
q5 2.91 2.74 -0.169 94.18%
q96 17.42 17.46 0.035 100.20%
q97 1.94 2.02 0.080 104.14%
q98 10.43 10.21 -0.217 97.92%
q99 10.43 10.21 -0.217 97.92%
total 2169.14 2192.41 23.272 101.07%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_08_22_2024_time.csv log/native_master_08_21_2024_fbd066a8e6_time.csv difference percentage
q1 40.75 40.11 -0.641 98.43%
q2 29.92 29.85 -0.072 99.76%
q3 52.08 53.61 1.529 102.94%
q4 41.89 41.68 -0.218 99.48%
q5 105.35 107.77 2.418 102.30%
q6 13.04 13.03 -0.015 99.88%
q7 117.08 116.21 -0.877 99.25%
q8 116.07 116.50 0.430 100.37%
q9 167.88 169.24 1.361 100.81%
q10 65.34 65.91 0.565 100.87%
q11 26.49 27.11 0.620 102.34%
q12 31.70 30.53 -1.167 96.32%
q13 52.26 52.12 -0.145 99.72%
q14 27.23 27.39 0.160 100.59%
q15 52.59 54.11 1.524 102.90%
q16 19.24 19.44 0.197 101.02%
q17 132.20 129.61 -2.585 98.04%
q18 198.60 198.26 -0.338 99.83%
q19 25.81 26.31 0.499 101.93%
q20 41.51 42.09 0.583 101.41%
q21 390.76 386.50 -4.260 98.91%
q22 15.80 17.58 1.788 111.32%
total 1763.60 1764.95 1.356 100.08%

sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
…ion inherited from parent pom (apache#6972)

This could fix build errors Intellij Idea IDE when scala-2.13 profile and spark-3.2/spark-3.3/spark-3.4 profiles are toggled on at the same time.

And with essential code cleanups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants