Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CH] Enable more uts in GlutenOrcV1SchemaPruningSuite #6895

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

taiyang-li
Copy link
Contributor

@taiyang-li taiyang-li commented Aug 16, 2024

What changes were proposed in this pull request?

Enable more uts in GlutenOrcV1SchemaPruningSuite, after ClickHouse/ClickHouse#59318 is merged.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions github-actions bot added the CORE works for Gluten Core label Aug 16, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

2 similar comments
Copy link

Run Gluten Clickhouse CI

@taiyang-li
Copy link
Contributor Author

Run Gluten Clickhouse CI

@taiyang-li
Copy link
Contributor Author

taiyang-li commented Aug 22, 2024

@PHILO-HE could you see why velox core dump happened in the failed CI. I didn't change any velox code

https://github.com/apache/incubator-gluten/actions/runs/10451326855/job/28937591263?pr=6895
image

Copy link

Run Gluten Clickhouse CI

@taiyang-li taiyang-li force-pushed the enable_vectorized_uts branch 2 times, most recently from 15ed220 to b279a08 Compare August 22, 2024 03:01
Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

@taiyang-li
Copy link
Contributor Author

image

new velox ci failures, cc @PHILO-HE

@PHILO-HE
Copy link
Contributor

@taiyang-li, for the core dump issue, please ignore it in your pr. We will track it. For the 2nd missing mvn issue, we have created one pr to fix it, which is expected to be merged soon. Sorry for inconvenience.

@taiyang-li
Copy link
Contributor Author

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taiyang-li taiyang-li merged commit 6352640 into apache:main Aug 27, 2024
43 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
* enable vectorized uts

* commit again

* finish dev

* enable more uts about GlutenOrcV1SchemaPruningSuite

* fix failed uts

* fix failed uts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants