-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CH] Enable more uts in GlutenOrcV1SchemaPruningSuite #6895
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
2 similar comments
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
@PHILO-HE could you see why velox core dump happened in the failed CI. I didn't change any velox code https://github.com/apache/incubator-gluten/actions/runs/10451326855/job/28937591263?pr=6895 |
Run Gluten Clickhouse CI |
15ed220
to
b279a08
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
new velox ci failures, cc @PHILO-HE |
@taiyang-li, for the core dump issue, please ignore it in your pr. We will track it. For the 2nd missing mvn issue, we have created one pr to fix it, which is expected to be merged soon. Sorry for inconvenience. |
b279a08
to
826107d
Compare
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* enable vectorized uts * commit again * finish dev * enable more uts about GlutenOrcV1SchemaPruningSuite * fix failed uts * fix failed uts
What changes were proposed in this pull request?
Enable more uts in GlutenOrcV1SchemaPruningSuite, after ClickHouse/ClickHouse#59318 is merged.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)