Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate different queries depending on the postgresql version #914

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

bchapuis
Copy link
Member

@bchapuis bchapuis commented Jan 11, 2025

Generate different queries depending on the postgresql version.

Recent versions of postgis will use subqueries as the query optimizer allows it. This allows for more complex user provided queries in the tileset. Legacy versions (<16) append conditions to the user provided queries to allow for better performance.

Caching is not needed anymore as String concatenation is faster than query parsing.
@bchapuis bchapuis force-pushed the 913-temporary-solution branch from edbe365 to e4fcfbf Compare January 11, 2025 15:48
@bchapuis
Copy link
Member Author

@AlexGacon Could you confirm that the version below is still working for your use case? If so, I will merge this PR and start the release process.

https://github.com/apache/incubator-baremaps/releases/tag/v0.8.2-test5

@AlexGacon
Copy link
Contributor

@bchapuis it still works perfectly!

@bchapuis bchapuis merged commit 8c65a30 into main Jan 14, 2025
11 checks passed
@bchapuis bchapuis deleted the 913-temporary-solution branch January 14, 2025 08:11
@bchapuis
Copy link
Member Author

Great, thank you for the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants