IGNITE-24323 SQL Calcite: Add query blocking tasks executor (allows t… #11833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-plekhanov
force-pushed
the
ignite-24323
branch
5 times, most recently
from
d8c8b98 to
80e7f30
Compare
…o execute SQL inside UDF)
alex-plekhanov
force-pushed
the
ignite-24323
branch
from
80e7f30 to
dfc23ed
Compare
nizhikov
reviewed
Jan 29, 2025
...src/main/java/org/apache/ignite/internal/processors/query/calcite/CalciteQueryProcessor.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Jan 29, 2025
...te/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/task/QueryKey.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Jan 29, 2025
...main/java/org/apache/ignite/internal/processors/query/calcite/exec/task/QueryTasksQueue.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Jan 29, 2025
.../main/java/org/apache/ignite/internal/processors/query/calcite/exec/task/QueryAwareTask.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Jan 29, 2025
...org/apache/ignite/internal/processors/query/calcite/exec/task/QueryBlockingTaskExecutor.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Jan 29, 2025
| eHnd = ctx.uncaughtExceptionHandler(); | ||
|
|
||
| executor = new IgniteThreadPoolExecutor( | ||
| "calciteQry", |
There was a problem hiding this comment.
All other pools names starts with capital letter.
Let's call it CalciteQueryAwareExecutor and the default one CalciteExecutor.
There was a problem hiding this comment.
It's not a pool name, it's thread prefix. All other thread prefixes start with non-capital letters.
…o execute SQL inside UDF)
nizhikov
reviewed
Jan 29, 2025
...main/java/org/apache/ignite/internal/processors/query/calcite/exec/task/QueryTasksQueue.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Jan 29, 2025
Comment on lines
150
to
158
| for (Node pred = head, cur = pred.next; cur != null; pred = cur, cur = cur.next) { | ||
| if (!blockedQrys.contains(cur.item.queryKey())) { // Skip tasks for blocked queries. | ||
| QueryAwareTask res = cur.item; | ||
|
|
||
| unlink(cur, pred); | ||
|
|
||
| return res; | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's rewite this with the while as it simplify the flow.
Suggested change
| for (Node pred = head, cur = pred.next; cur != null; pred = cur, cur = cur.next) { | |
| if (!blockedQrys.contains(cur.item.queryKey())) { // Skip tasks for blocked queries. | |
| QueryAwareTask res = cur.item; | |
| unlink(cur, pred); | |
| return res; | |
| } | |
| } | |
| Node pred = head; | |
| Node cur = pred.next; | |
| while (cur != null) { | |
| if (!blockedQrys.contains(cur.item.queryKey())) { // Skip tasks for blocked queries. | |
| QueryAwareTask res = cur.item; | |
| unlink(cur, pred); | |
| return res; | |
| } | |
| pred = cur; | |
| cur = cur.next; | |
| } |
There was a problem hiding this comment.
It's a matter of taste, I think there is no simplification with while
nizhikov
reviewed
Jan 29, 2025
...main/java/org/apache/ignite/internal/processors/query/calcite/exec/task/QueryTasksQueue.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Jan 29, 2025
...main/java/org/apache/ignite/internal/processors/query/calcite/exec/task/QueryTasksQueue.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Jan 29, 2025
...main/java/org/apache/ignite/internal/processors/query/calcite/exec/task/QueryTasksQueue.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Jan 29, 2025
...main/java/org/apache/ignite/internal/processors/query/calcite/exec/task/QueryTasksQueue.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Jan 29, 2025
|
|
||
| try { | ||
| for (Node pred = head, cur = pred.next; cur != null; pred = cur, cur = cur.next) { | ||
| if (task.equals(cur.item)) { |
There was a problem hiding this comment.
Do we really need equals here? Not ==?
nizhikov
approved these changes
Jan 29, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o execute SQL inside UDF)
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.