OpenAPI: add initial/write defaults to schema #12094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
LGTM! Aligns with V3 default values from the spec
https://iceberg.apache.org/spec/#default-values
flyrain
approved these changes
Jan 24, 2025
rdblue
reviewed
Jan 24, 2025
rdblue
reviewed
Jan 24, 2025
core/src/test/java/org/apache/iceberg/rest/requests/TestCreateTableRequest.java
Show resolved
Hide resolved
gaborkaszab
reviewed
Jan 27, 2025
core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponse.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
inital-defaultandwrite-defaultto the REST API spec.Includes updates to a couple small round-trip request/response serde tests.