Parquet: Fix Reader leak by removing useless copy #12079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ReadConf copy constructor will nullify the reader of source, leaving the reader of original unclosed
|
leak stacktrace looks like(iceberg 1.2.x) |
Fokko
changed the title
Fokko
approved these changes
Jan 24, 2025
nastra
approved these changes
Jan 24, 2025
|
Wait, I think the fix is incorrect.
The readConf do transfer ownership to FileIterator via init return, in
which should be cloused by caller.
…On Fri, Jan 24, 2025 at 19:10 Eduard Tudenhoefner ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#12079 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKPIB4YB5LZQQHME57ZDT2MINTFAVCNFSM6AAAAABVYZGKW2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZSGM3DENBXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I think I found the root cause. comments inline. static SeekableInputStream stream(org.apache.iceberg.io.SeekableInputStream stream) {
if (stream instanceof DelegatingInputStream) {
// for somehow, it tries to optimistic steal the underlying stream, creating a new one by wrapping it.
// the caller close the wrapper and underlying stream but not this intermediate one.
InputStream wrapped = ((DelegatingInputStream) stream).getDelegate();
if (wrapped instanceof FSDataInputStream) {
return HadoopStreams.wrap((FSDataInputStream) wrapped);
}
}
return new ParquetInputStreamAdapter(stream);
}A similar approach for the output version. Can we just go through the Adapter path? |
This reverts commit 6b655c0.
Wrapping required a clear way to call close of the provided stream, without also closing the underlying stream.
nastra
reviewed
Jan 24, 2025
| @@ -82,22 +82,10 @@ static OutputFile file(org.apache.iceberg.io.OutputFile file, Configuration conf | |||
| } | |||
|
|
|||
| static SeekableInputStream stream(org.apache.iceberg.io.SeekableInputStream stream) { | |||
| if (stream instanceof DelegatingInputStream) { | |||
There was a problem hiding this comment.
could you please add a test that tries to reproduce the original problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReadConf copy constructor will nullify the reader of source, leaving the reader of original unclosed