WIP: Fix never expire current ViewVersion #12051
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: For now this is just the breaking test which I believe should work.
The actual fix is missing.
Currently if more and more
ViewVersion
are added to the Metadata, eventually even the current version will expire. Currently expiration works as follows:The problem occurs if we add view versions but never set them current. In this case the versions pile up and we eventually expire the whole view log as well as the current view version. I don't think this is desired behavior. This is a niche problem, as most clients create a view and set it active immediately.
I see two solutions:
view_log
(previously current view versions). We would need another mechanism to expire the versions itself though. Is there a good use-case to keep a version that is neither current nor part of theview_log
?CC @nastra