Core, Test: Parsing and Writing Tests for V3 Metadata #12025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameterize TestTableMetadata
# Conflicts: # core/src/test/java/org/apache/iceberg/TestTableMetadata.java
HonahX
changed the title
Fokko
reviewed
Jan 22, 2025
| @Test | ||
| public void testInvalidMainBranch() throws IOException { | ||
| @ParameterizedTest | ||
| @FieldSource("org.apache.iceberg.TestHelpers#ALL_VERSIONS") |
There was a problem hiding this comment.
Instead of this, we could also put it as:
Suggested change
| @FieldSource("org.apache.iceberg.TestHelpers#ALL_VERSIONS") | |
| @ValueSource(ints = MIN_FORMAT_VERSION_V2) |
This avoids having to rely on the assumeThat, which I feel makes it harder to interpret the test. I'm not super strong on this, though. Maybe our test-connaisseur @nastra can share his opinion here.
There was a problem hiding this comment.
I'd suggest to do the same as mentioned in #11948 (comment) and parameterize this at the class level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be part of #11947 that does not include new unsafe builders for Snapshot and TableMetadata.