Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix latest and nightly link on javadoc (according to site README.md) #12023

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbonofre
Copy link
Member

No description provided.

@github-actions github-actions bot added the docs label Jan 21, 2025
@jbonofre jbonofre requested review from Fokko and manuzhang January 21, 2025 17:20
@jbonofre jbonofre mentioned this pull request Jan 21, 2025
@jbonofre
Copy link
Member Author

As discussed on #10378 @Fokko @manuzhang

@manuzhang
Copy link
Collaborator

@jbonofre
I built the site based on the PR locally. The Javadoc links from nightly / latest are working now, but links from 1.7.1 / 1.7.0 / 1.6.1 / 1.6.0 all point to latest. Links from older releases are also working fine.

@jbonofre
Copy link
Member Author

@manuzhang I didn't change the versions. Let me check.

@jbonofre
Copy link
Member Author

@manuzhang I checked, and I see 1.7.1, 1.7.0 etc folders in javadoc (without sym link). I guess you are talking about the links in the generated site/index.html ? Can you point me to the exact page ?

@jbonofre
Copy link
Member Author

Ah I found it and it's not related to this change.
If you go to iceberg.apache.org (https://iceberg.apache.org/docs/nightly), you can see the Javadoc links are pointing to latest.
So this is an issue that exists already. I'm ok to fix it as part of this PR 😄

@manuzhang
Copy link
Collaborator

I see. We can fix it separately.

@jbonofre
Copy link
Member Author

I chatted with @Fokko and the javadoc version links to latest is a known issue and a bit complicated to fix.

I propose to merge this PR (with latest & nightly links fix) and create another PR to fix the javadoc version links.

@jbonofre
Copy link
Member Author

@Fokko what do you think about this one ?

@jbonofre
Copy link
Member Author

@Fokko gentle reminder 😄 Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants