Implement basic support for rest.sigv4_enabled
for the Iceberg REST catalog
#917
+450
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements basic support for connecting to the AWS Glue Iceberg REST catalog by supporting the parameters
rest.sigv4-enabled
,rest.signing-name
andrest.signing-region
. See the corresponding parameters in the PyIceberg docs: https://py.iceberg.apache.org/configuration/#rest-catalogI've added a new feature to the
iceberg-catalog-rest
calledsigv4
which when enabled, will recognize the above configuration parameters. I've left this disabled by default.I added the crate
request_middleware
to allow running middleware on requests, and if therest.sigv4-enabled
configuration is enabled, the middleware to sign the request and add the correctAuthorization
header is enabled.I've tested this implementation in my project, and it works great for connecting to the AWS Glue REST catalog, i.e.
https://glue.<region>.amazonaws.com/iceberg
I based this logic on the equivalent logic in PyIceberg: https://github.com/apache/iceberg-python/blob/6fffb644518bb64e8f33883d850edbe18c12bd07/pyiceberg/catalog/rest.py#L475