refactor: refine writer interface to support directory hierarchy #893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to resolve #891. On our original design, we allow the user to create the writer builder and combine them and build them finally. However, original design is not support to change the config of builder after we combine them. But in some case, we hope to recreate the writer for different partition using writer builder. E.g. in #819, we want to regenerate the table location for different partition. So I follow the design from iceberg-java https://github.com/apache/iceberg/blob/d96901b843395fe669f6bd4f618f8e5e46c0eed4/core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java#L334 :
SinglePartitionWriterBuilder
.It's the responsibility of SinglePartitionWriterBuilder to create the OutputFile. And the build function of SinglePartitionWriterBuilder take a partition value which means that we can create different partition of writer from this Builder.