fix: allow nullable field of equality delete writer #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @liurenjie1024 @Fokko @Xuanwo @sdd I think this PR is ready to go |
ZENOTME
force-pushed
the
fix_eq_delete
branch
from
7b18773 to
80db872
Compare
| @@ -148,8 +150,11 @@ impl RecordBatchProjector { | |||
| ))? | |||
| .column(*idx) | |||
| .clone(); | |||
| null_buffer = NullBuffer::union(null_buffer.as_ref(), array.logical_nulls().as_ref()); | |||
There was a problem hiding this comment.
Do we actually need to do this? I assume if parent struct element is null, its child is also null?
There was a problem hiding this comment.
Yes. E.g. in
, for the second value of struct, the parent struct element is null but it's child actually has valid element.There was a problem hiding this comment.
Could you add some test for more deeply nested struct type? For example struct(struct(int))?
There was a problem hiding this comment.
Sure, I have add it.
liurenjie1024
previously approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Thanks @ZENOTME for fixing this, generally LGTM, just left a small question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the doc fixed in apache/iceberg#8981, the equality delete writer can have an optional field id. This PR fixes this.