-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return builder from setHostnameVerificationPolicy #588
Conversation
@osipxd Damn. This is an API breaking change. We will have to deprecate this method and add another one with a different name. What is even more worrisome is the API breakage has not been detected by the build. |
@osipxd I suppose I was wrong. The return type is not a part of method name signature and changing return type from void to something else does not cause compile incompatibility. |
Cherry-picked to |
I tried changing the return type on a static method in a different project (Apache Commons IO) and JApiCmp failed with:
We are not using the latest version in HC parent, so this could be a bug in an old version of JApiCmp. The JLS says that changing a return type is the same as removing and adding a method. |
|
I'm still skeptical, this looks to me like 2 bugs in JApiCmp 😞
After I run:
JApiCmp thinks the method is "NEW" and "METHOD_ADDED_TO_PUBLIC_CLASS". Instead, I think it should report "METHOD_RETURN_TYPE_CHANGED". It should also note the change from non- There's been a few bugs in this area: https://github.com/siom79/japicmp/issues?q=is%3Aissue++return+ |
@garydgregory Do you want me to revert the commit and ask @osipxd to re-spin the PR with a more conservative fix? |
Hi @ok2c |
@garydgregory @osipxd Commit reverted and replaced by 001eff7 Please take a look |
LGTM, TY. |
Currently, it is impossible to add
setHostnameVerificationPolicy
to a call chain