Performance and code optimization in HTTP cache #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arturobernalg Please take a look. |
…; avoid parsing DATE header of cache entries and HTTP messages multiple times
…heKeyGenerator; added test cases
arturobernalg
approved these changes
Oct 24, 2023
| @@ -258,7 +253,7 @@ protected boolean isExplicitlyNonCacheable(final ResponseCacheControl cacheContr | |||
| } | |||
|
|
|||
| protected boolean isExplicitlyCacheable(final ResponseCacheControl cacheControl, final HttpResponse response) { | |||
There was a problem hiding this comment.
We're calling isExplicitlyCacheable twice within the isResponseCacheable method. Maybe we could storing its result in a variable and reusing it.
There was a problem hiding this comment.
We're calling
isExplicitlyCacheabletwice within theisResponseCacheablemethod. Maybe we could storing its result in a variable and reusing it.
@arturobernalg True. However, It is relatively cheap and the first invocation gets executed conditionally. I think It is not worth the ugliness of having an extra parameter to pass around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching code optimization
CacheSupportResponseCachingPolicy#isResponseCacheableby parsing responseDATEandEXPIRESheaders only onceHttpCacheEntryto cache parsedDATE,EXPIRESandLAST_MODIFIEDvaluesHttpCacheEntryto avoid parsingDATEheader of cache entries and HTTP messages multiple times