Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPCLIENT-2302: Add comment to TrustStrategy usage in examples #492

Merged
merged 2 commits into from
Oct 12, 2023
Merged

HTTPCLIENT-2302: Add comment to TrustStrategy usage in examples #492

merged 2 commits into from
Oct 12, 2023

Conversation

Marcono1234
Copy link
Contributor

See also discussion in https://issues.apache.org/jira/browse/HTTPCLIENT-2302

This tries to make the user aware that:

  • Usage of TrustStrategy is optional
  • The specific usage in the examples does not prevent man-in-the-middle attacks

Feedback is appreciated!

@ok2c ok2c merged commit 6b16ec1 into apache:master Oct 12, 2023
9 checks passed
@Marcono1234 Marcono1234 deleted the ssl-examples-comment branch October 12, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants