HTTPCLIENT-2284: internal cache storage improvements #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturobernalg
approved these changes
Aug 27, 2023
There was a problem hiding this comment.
@ok2c the change-set looks good. I just add a small question.
| private final Queue<HttpCacheStorageEntry> evictionQueue; | ||
| private final Consumer<HttpCacheStorageEntry> evictionCallback; | ||
|
|
||
| public InternalCacheStorage(final int maxEntries, final Consumer<HttpCacheStorageEntry> evictionCallback) { |
There was a problem hiding this comment.
shouldn't we check if maxEntriesis positives?
There was a problem hiding this comment.
@arturobernalg I would say not. Not at this level. Input validation should be done at the public API level,
lacompas
reviewed
Aug 28, 2023
|
|
||
| @Override | ||
| protected boolean removeEldestEntry(final Map.Entry<String, HttpCacheEntry> eldest) { | ||
| if (evictionCallback != null && size() > maxEntries) { |
There was a problem hiding this comment.
This is a change in behaviour, now the maxEntries size limit is no longer honoured by default
ok2c
added a commit
that referenced
this pull request
Aug 28, 2023
ok2c
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added internal cache storage implementation that can be used to implement custom cache storage backends with specific cache entry eviction strategy.
@arturobernalg Please review.