GUACAMOLE-1996: Adding Dvorak ES keyboard layout #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned on apache/guacamole-server#562, you'll need to create that Jira issue (and a Jira account, if you don't already have it), and tag the PR and commits with that information. |
tetebueno
changed the title
|
Just generated the following issue: https://issues.apache.org/jira/projects/GUACAMOLE/issues/GUACAMOLE-1996?filter=allopenissues |
necouchman
reviewed
Oct 24, 2024
| @@ -109,6 +109,7 @@ | |||
| "en-gb-qwerty", | |||
| "en-us-qwerty", | |||
| "es-es-qwerty", | |||
| "es-es-dvorak", | |||
There was a problem hiding this comment.
This is a minor thing, but es-es-dvorak should be above es-es-qwerty, alphabetically - here, and in the other files you've updated in the client code.
There was a problem hiding this comment.
Done. Now checking how to fix server's PR build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Spanish Dvorak keyboard layout included in Ubuntu distributions.