GROOVY-11297: Fail to identify duplicate constructor declaration

apache · Jan 25, 2024 · f0f62d6 · f0f62d6
1 parent 8f668bd
commit f0f62d6
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/main/java/org/codehaus/groovy/classgen/Verifier.java b/src/main/java/org/codehaus/groovy/classgen/Verifier.java
@@ -268,6 +268,7 @@ public void visitClass(final ClassNode node) {
         node.getObjectInitializerStatements().clear();
         node.visitContents(this);
         checkForDuplicateMethods(node);
+        checkForDuplicateConstructors(node);
         addCovariantMethods(node);
         detectNonSealedClasses(node);
         checkFinalVariables(node);
@@ -393,6 +394,18 @@ private static void checkForDuplicateMethods(final ClassNode cn) {
         }
     }
 
+    private static void checkForDuplicateConstructors(final ClassNode cn) {
+        Set<String> descriptors = new HashSet<>();
+        for (ConstructorNode cons : cn.getDeclaredConstructors()) {
+            String mySig = methodDescriptorWithoutReturnType(cons);
+            if (descriptors.contains(mySig)) {
+                throw new RuntimeParserException("The constructor " + cons.getText() +
+                    " duplicates another constructor of the same signature", sourceOf(cons));
+            }
+            descriptors.add(mySig);
+        }
+    }
+
     private static String scriptBodySignatureWithoutReturnType(final ClassNode cn) {
         for (MethodNode mn : cn.getMethods()) {
             if (mn.isScriptBody()) return methodDescriptorWithoutReturnType(mn);

diff --git a/src/test/gls/classes/methods/RepetitiveMethodTest.groovy b/src/test/gls/classes/methods/RepetitiveMethodTest.groovy
@@ -48,4 +48,14 @@ class RepetitiveMethodTest extends CompilableTestSupport {
             }
         '''
     }
+
+    void testRepetitiveConstructor() {
+        def message = shouldNotCompile('''
+            class A {
+                A(int x) {}
+                A(int y) {}
+            }
+        ''')
+        assert message.contains('duplicates another constructor of the same signature')
+    }
 }