Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GORA-276: Refactor and organize o.a.g.mapreduce package naming #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nbrendah
Copy link

Issue Link: https://issues.apache.org/jira/browse/GORA-276

Migrated classes in package org.apache.gora.mapreduce to org.apache.gora.io.serializer

cc @djkevincr

@nbrendah
Copy link
Author

nbrendah commented Oct 28, 2021

My PR is failing. @lewismc, what is the cause of

Going to parse results form **/*-reports/TEST-*.xml
Result: 1352 tests run, 29 skipped, 0 failed.
Posting status 'completed' with conclusion 'success' to https://github.com/apache/gora/pull/251 (sha: 07293dc17249838fb781c01ca624318f4b29917e)
Error: Resource not accessible by integration

Screenshot from 2021-10-29 00-49-19

@lewismc
Copy link
Member

lewismc commented Oct 28, 2021

Yeah I saw that and I tried to fix it.
@djkevincr do you know when the Github Actions build started failing?
I did see actions/first-interaction#10 (comment)

@nbrendah
Copy link
Author

nbrendah commented Oct 28, 2021

Yeah I saw that and I tried to fix it.

@lewismc I saw your current commit 44ecabb . It was passing build, though failing with sonar scanners.
However, most of these builds pass locally.

@lewismc
Copy link
Member

lewismc commented Nov 4, 2021

This is a real blast from the past @nbrendah
This patch introduces a major API break... so we need to think about how clients will address that.

@nbrendah
Copy link
Author

nbrendah commented Nov 8, 2021

Sorry @lewismc for taking long without replying to this. I was finishing my outreachy application

This patch introduces a major API break... so we need to think about how clients will address that.

@lewismc @djkevincr Should we create documentation to show this change or I close this because negative results outweigh the positive?

@nbrendah
Copy link
Author

nbrendah commented Nov 9, 2021

I had to send an empty commit to re-run the build.
I guess it passes and we continue with our discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants