Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37125] [conf] fixed env.log.max java.lang.NumberFormatException #26037

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sehajsandhu123
Copy link

What is the purpose of the change

Fix for NumberFormatException in Log Configuration
This PR resolves an issue where the log.max parameter in config.yaml was treated as a string, causing a java.lang.NumberFormatException when parsed by the DefaultRolloverStrategy plugin.

Changes:
Updated the config.sh script to clean up MAX_LOG_FILE_NUMBER by removing leading and trailing single quotes before parsing.

Testing:
Verified correct parsing of config env.log.max in a real Hadoop 3.3.6 cluster.
Confirmed the history server starts without errors after the change.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 21, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is tolerating a string for a field that should be numeric. Would it not be better to check that the token is a number and give an error if it is not a number (e.g. if it is a string including a string that is a quoted number?)

@davidradl
Copy link
Contributor

Reviewed by Chi on 23/01/2025 Go back to the submitter with review comments.

@sehajsandhu123
Copy link
Author

@davidradl
The reason for tolerating strings is that ConfigurationParserUtils.loadAndModifyConfiguration inherently processes all YAML configuration values as strings due to how Configuration.toFileWritableMap serializes data using YamlParserUtils.toYAMLString. This results in numeric values being wrapped as strings (e.g., '10').

This fix handles this behaviour by removing unnecessary quotes to ensure the value is interpreted correctly. Adding an error check here might result in false positives, as numeric values are always converted to strings in config.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants