Kubernetes service discovery breaking change in version 29.0.0 #17529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likely to have been introduced by #15449 |
this looks good to me, @m17kea can you add a note that the operator might need to delete the configmap multiple times? for example if they have two coordinators or overlords running and are doing a rolling update, and one of the old coordinators/overlords regains leadership after the configmap is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15942
Description
This PR updates the Apache Druid documentation to highlight a breaking change in Kubernetes service discovery behavior introduced in version 29. Specifically, the format of the timestamps used in the
<cluster-identifier>-leaderelection-coordinatorand<cluster-identifier>-leaderelection-overlordConfigMaps was updated to a new format that was not documented. This change caused errors during leader election and service discovery due to mismatched date parsing expectations.The goal of this PR is to ensure that users upgrading to version 29 are aware of this breaking change and can make the necessary adjustments to avoid issues in their Druid clusters.
Documentation Changes
Added a note in the Upgrade notes documentation for version 29 about the updated date format in ConfigMaps.
Provided an example of the command required to help users update their clusters accordingly.
Release Note
This PR updates the documentation to warn users about a breaking change in Kubernetes service discovery introduced in version 29. The date format in leader election ConfigMaps (
<cluster-identifier>-leaderelection-coordinatorand<cluster-identifier>-leaderelection-overlord) was updated to a stricter ISO-8601-like format. Users should ensure they delete the old config mapss once upgrade to version 29.0.0 and above so they are recreated with the correct date format.Key changed/added classes in this PR Documentation updates only, no code changes.
This PR has: