-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move First Value UDAF and builtin first / last function to aggregate-functions
#9960
Merged
+720
−570
Merged
Changes from 30 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
0eaf289
backup
jayzhan211 5338f61
move PhysicalExpr
jayzhan211 450ae4b
cleanup
jayzhan211 3624964
move physical sort
jayzhan211 835f147
cleanup dependencies
jayzhan211 c5d80c8
add readme
jayzhan211 7851de7
disable doc test
jayzhan211 f5aafb3
move column
jayzhan211 7bfc074
fmt
jayzhan211 675d2fe
move aggregatexp
jayzhan211 5220087
move other two utils
jayzhan211 113a000
license
jayzhan211 fea87e3
switch to ignore
jayzhan211 06d87bc
move reverse order
jayzhan211 26e5782
rename to common
jayzhan211 26f852c
cleanup
jayzhan211 65bf4a1
Merge branch 'physical-expr-core' into move-agg-crate-2
jayzhan211 2bc58c1
backup
jayzhan211 ae9db96
Merge branch 'physical-expr-core' into move-agg-crate-2
jayzhan211 30d5576
move acc to first value
jayzhan211 672edc7
move builtin expr too
jayzhan211 109b790
use macro
jayzhan211 87d589f
fmt
jayzhan211 398e4e2
fix doc
jayzhan211 04c7f5e
add todo
jayzhan211 01a1ddf
rm comments
jayzhan211 4871414
rm unused
jayzhan211 1ef212b
rm unused code
jayzhan211 b6d53a5
change to private
jayzhan211 9aa15a2
fix lock
jayzhan211 e90464b
cleanup
jayzhan211 ece925f
cleanup
jayzhan211 89ccc89
support roundtrip
jayzhan211 41a830a
remmove old format state
jayzhan211 d235d2a
move aggregate related things to aggr crate
jayzhan211 51cd272
move back to common
jayzhan211 38b2ce7
taplo
jayzhan211 9c7767c
rm comment
jayzhan211 ea4adde
cleanup
jayzhan211 39c5d15
lock
jayzhan211 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
[package] | ||
name = "datafusion-aggregate-functions" | ||
description = "Aggregate function packages for the DataFusion query engine" | ||
keywords = ["datafusion", "logical", "plan", "expressions"] | ||
readme = "README.md" | ||
version = { workspace = true } | ||
edition = { workspace = true } | ||
homepage = { workspace = true } | ||
repository = { workspace = true } | ||
license = { workspace = true } | ||
authors = { workspace = true } | ||
rust-version = { workspace = true } | ||
|
||
[lib] | ||
name = "datafusion_aggregate_functions" | ||
path = "src/lib.rs" | ||
|
||
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | ||
|
||
[dependencies] | ||
arrow = { workspace = true } | ||
datafusion-common = { workspace = true } | ||
datafusion-execution = { workspace = true } | ||
datafusion-expr = { workspace = true } | ||
datafusion-physical-expr-common = { workspace = true } | ||
log = { workspace = true } | ||
paste = "1.0.14" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about calling the new crate
datafusion-functions-aggregates
(to mirror the naming ofdatafusion-functions
anddatafusion-functions-array
)?