Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move First Value UDAF and builtin first / last function to aggregate-functions #9960

Merged
merged 40 commits into from
Apr 7, 2024
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
0eaf289
backup
jayzhan211 Apr 3, 2024
5338f61
move PhysicalExpr
jayzhan211 Apr 3, 2024
450ae4b
cleanup
jayzhan211 Apr 3, 2024
3624964
move physical sort
jayzhan211 Apr 3, 2024
835f147
cleanup dependencies
jayzhan211 Apr 3, 2024
c5d80c8
add readme
jayzhan211 Apr 3, 2024
7851de7
disable doc test
jayzhan211 Apr 3, 2024
f5aafb3
move column
jayzhan211 Apr 4, 2024
7bfc074
fmt
jayzhan211 Apr 4, 2024
675d2fe
move aggregatexp
jayzhan211 Apr 4, 2024
5220087
move other two utils
jayzhan211 Apr 4, 2024
113a000
license
jayzhan211 Apr 4, 2024
fea87e3
switch to ignore
jayzhan211 Apr 4, 2024
06d87bc
move reverse order
jayzhan211 Apr 4, 2024
26e5782
rename to common
jayzhan211 Apr 4, 2024
26f852c
cleanup
jayzhan211 Apr 5, 2024
65bf4a1
Merge branch 'physical-expr-core' into move-agg-crate-2
jayzhan211 Apr 5, 2024
2bc58c1
backup
jayzhan211 Apr 5, 2024
ae9db96
Merge branch 'physical-expr-core' into move-agg-crate-2
jayzhan211 Apr 5, 2024
30d5576
move acc to first value
jayzhan211 Apr 5, 2024
672edc7
move builtin expr too
jayzhan211 Apr 5, 2024
109b790
use macro
jayzhan211 Apr 5, 2024
87d589f
fmt
jayzhan211 Apr 5, 2024
398e4e2
fix doc
jayzhan211 Apr 5, 2024
04c7f5e
add todo
jayzhan211 Apr 5, 2024
01a1ddf
rm comments
jayzhan211 Apr 5, 2024
4871414
rm unused
jayzhan211 Apr 5, 2024
1ef212b
rm unused code
jayzhan211 Apr 5, 2024
b6d53a5
change to private
jayzhan211 Apr 5, 2024
9aa15a2
fix lock
jayzhan211 Apr 5, 2024
e90464b
cleanup
jayzhan211 Apr 5, 2024
ece925f
cleanup
jayzhan211 Apr 5, 2024
89ccc89
support roundtrip
jayzhan211 Apr 5, 2024
41a830a
remmove old format state
jayzhan211 Apr 6, 2024
d235d2a
move aggregate related things to aggr crate
jayzhan211 Apr 6, 2024
51cd272
move back to common
jayzhan211 Apr 6, 2024
38b2ce7
taplo
jayzhan211 Apr 6, 2024
9c7767c
rm comment
jayzhan211 Apr 7, 2024
ea4adde
cleanup
jayzhan211 Apr 7, 2024
39c5d15
lock
jayzhan211 Apr 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ members = [
"datafusion/core",
"datafusion/expr",
"datafusion/execution",
"datafusion/aggregate-functions",
"datafusion/functions",
"datafusion/functions-array",
"datafusion/optimizer",
Expand Down Expand Up @@ -73,6 +74,7 @@ chrono = { version = "0.4.34", default-features = false }
ctor = "0.2.0"
dashmap = "5.4.0"
datafusion = { path = "datafusion/core", version = "37.0.0", default-features = false }
datafusion-aggregate-functions = { path = "datafusion/aggregate-functions", version = "37.0.0" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about calling the new crate datafusion-functions-aggregates (to mirror the naming of datafusion-functions and datafusion-functions-array)?

datafusion-common = { path = "datafusion/common", version = "37.0.0", default-features = false }
datafusion-common-runtime = { path = "datafusion/common-runtime", version = "37.0.0" }
datafusion-execution = { path = "datafusion/execution", version = "37.0.0" }
Expand Down
15 changes: 15 additions & 0 deletions datafusion-cli/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 44 additions & 0 deletions datafusion/aggregate-functions/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

[package]
name = "datafusion-aggregate-functions"
description = "Aggregate function packages for the DataFusion query engine"
keywords = ["datafusion", "logical", "plan", "expressions"]
readme = "README.md"
version = { workspace = true }
edition = { workspace = true }
homepage = { workspace = true }
repository = { workspace = true }
license = { workspace = true }
authors = { workspace = true }
rust-version = { workspace = true }

[lib]
name = "datafusion_aggregate_functions"
path = "src/lib.rs"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
arrow = { workspace = true }
datafusion-common = { workspace = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
datafusion-physical-expr-common = { workspace = true }
log = { workspace = true }
paste = "1.0.14"
Loading
Loading