refactor: add macro for the binary math function in datafusion-function
#9889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Weijun-H
force-pushed
the
util-math-binary-function
branch
from
b4be8a5 to
8cb744f
Compare
github-actions
bot
removed
logical-expr
Weijun-H
force-pushed
the
util-math-binary-function
branch
from
9fea373 to
2267af3
Compare
Weijun-H
changed the title
datafusion-function
alamb
approved these changes
Apr 1, 2024
| @@ -39,6 +37,7 @@ make_math_unary_udf!(AtanhFunc, ATANH, atanh, atanh, Some(vec![Some(true)])); | |||
| make_math_unary_udf!(AsinhFunc, ASINH, asinh, asinh, Some(vec![Some(true)])); | |||
| make_math_unary_udf!(AcoshFunc, ACOSH, acosh, acosh, Some(vec![Some(true)])); | |||
| make_math_unary_udf!(AtanFunc, ATAN, atan, atan, Some(vec![Some(true)])); | |||
| make_math_binary_udf!(Atan2, ATAN2, atan2, atan2, Some(vec![Some(true)])); | |||
|
I merged up from main so this PR will pass CI |
|
Thanks again @Weijun-H -- this is great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follows #9872
Rationale for this change
Originally posted by @alamb in #9872 (comment)
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?