Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for substr_index #9878

Merged
merged 20 commits into from
Apr 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions datafusion/functions/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,8 @@ required-features = ["datetime_expressions"]
harness = false
name = "to_char"
required-features = ["datetime_expressions"]

[[bench]]
harness = false
name = "substr_index"
required-features = ["unicode_expressions"]
103 changes: 103 additions & 0 deletions datafusion/functions/benches/substr_index.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

extern crate criterion;

use std::sync::Arc;

use arrow::array::{ArrayRef, Int64Array, StringArray};
use criterion::{black_box, criterion_group, criterion_main, Criterion};
use rand::distributions::{Alphanumeric, Uniform};
use rand::prelude::Distribution;
use rand::Rng;

use datafusion_expr::ColumnarValue;
use datafusion_functions::unicode::substr_index;

struct Filter<Dist, Test> {
dist: Dist,
test: Test,
}

impl<T, Dist, Test> Distribution<T> for Filter<Dist, Test>
where
Dist: Distribution<T>,
Test: Fn(&T) -> bool,
{
fn sample<R: Rng + ?Sized>(&self, rng: &mut R) -> T {
loop {
let x = self.dist.sample(rng);
if (self.test)(&x) {
return x;
}
}
}
}

fn data() -> (StringArray, StringArray, Int64Array) {
let dist = Filter {
dist: Uniform::new(-4, 5),
test: |x: &i64| x != &0,
};
let mut rng = rand::thread_rng();
let mut strings: Vec<String> = vec![];
let mut delimiters: Vec<String> = vec![];
let mut counts: Vec<i64> = vec![];

for _ in 0..1000 {
let length = rng.gen_range(20..50);
let text: String = (&mut rng)
.sample_iter(&Alphanumeric)
.take(length)
.map(char::from)
.collect();
let char = rng.gen_range(0..text.len());
let delimiter = &text.chars().nth(char).unwrap();
let count = rng.sample(&dist);

strings.push(text);
delimiters.push(delimiter.to_string());
counts.push(count);
}

(
StringArray::from(strings),
StringArray::from(delimiters),
Int64Array::from(counts),
)
}

fn criterion_benchmark(c: &mut Criterion) {
c.bench_function("substr_index_array_array_1000", |b| {
let (strings, delimiters, counts) = data();
let strings = ColumnarValue::Array(Arc::new(strings) as ArrayRef);
let delimiters = ColumnarValue::Array(Arc::new(delimiters) as ArrayRef);
let counts = ColumnarValue::Array(Arc::new(counts) as ArrayRef);

let args = [strings, delimiters, counts];
b.iter(|| {
black_box(
substr_index()
.invoke(&args)
.expect("substr_index should work on valid values"),
)
})
});
}

criterion_group!(benches, criterion_benchmark);
criterion_main!(benches);
Loading