Remove dependency on datafusion_catalog from datafusion-cli #14398
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 1, 2025
| @@ -48,7 +48,6 @@ datafusion = { path = "../datafusion/core", version = "44.0.0", features = [ | |||
| "unicode_expressions", | |||
| "compression", | |||
| ] } | |||
| datafusion-catalog = { path = "../datafusion/catalog", version = "44.0.0" } | |||
There was a problem hiding this comment.
the point of the PR is to remove this dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
I noticed this unnecessary dependency while working on
45.0.0#14008Rationale for this change
The
datafusioncrate should have all code / features necessary to use datafusion. Users shouldn't have to also use the subcrates.What changes are included in this PR?
Remove dependency on
datafusion_catalogand use the re-export indatafusioninsteadAre these changes tested?
Are there any user-facing changes?