Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression list Type Coercion List with inner type struct which has large/view types #14385

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 31, 2025

Which issue does this PR close?

Rationale for this change

See issue -- nested structs in Lists are not coerced correctly

What changes are included in this PR?

  1. Fix bug (basically the same fix in Do not rename struct fields when coercing types in CASE #14384 to the type_union resolution)
  2. Add tests

Are these changes tested?

Yes, new sqllogictests

Are there any user-facing changes?

Bug fix

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Jan 31, 2025
@alamb alamb changed the title Fix list Type Coercion List with inner type struct which has large/view types Fix regression list Type Coercion List with inner type struct which has large/view types Jan 31, 2025
@alamb alamb mentioned this pull request Jan 31, 2025
31 tasks
@alamb alamb closed this Jan 31, 2025
@alamb alamb reopened this Jan 31, 2025
@alamb alamb force-pushed the alamb/fix_inner_list_coercion branch from a578ebe to f0583a6 Compare February 1, 2025 12:13
@alamb alamb marked this pull request as ready for review February 1, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type Coercion fails for List with inner type struct which has large/view types
1 participant