Fully support LIKE/ILIKE with Utf8View #14379
Conversation
| @@ -819,10 +820,6 @@ impl<S: ContextProvider> SqlToRel<'_, S> { | |||
| return not_impl_err!("ANY in LIKE expression"); | |||
| } | |||
| let pattern = self.sql_expr_to_logical_expr(pattern, schema, planner_context)?; | |||
| let pattern_type = pattern.get_type(schema)?; | |||
There was a problem hiding this comment.
this is the code change -- don't do type checking in the planner
| @@ -1689,6 +1689,15 @@ true true false false true true | |||
| statement ok | |||
| drop table t1 | |||
|
|
|||
| # can't use like with non stirngs | |||
There was a problem hiding this comment.
this shows what happens when you try to run like on an integer 😆
| @@ -41,141 +41,6 @@ select arrow_cast(col1, 'Utf8') as c1 from test_substr_base; | |||
| # | |||
| include ./string_query.slt.part | |||
|
|
|||
| # TODO support all String types in sql_like_to_expr and move this test to `string_query.slt.part` | |||
There was a problem hiding this comment.
By moving these tests to string_query.slt.part they now run for strings, large strings, stringview and dictionary arrays
FYI @goldmedal
alamb
changed the title
There was a problem hiding this comment.
The change makes sense to me, thank you
I have one suggestion for additional test: now tests for StringView arrays are included, there are also tests for StringView literals can be added in https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/string/string_literal.slt, like select 'foo' like arrow_cast('foo', 'Utf8View')
Which issue does this PR close?
Rationale for this change
I wanted to ensure that we can fully support
LIKE/ILIKEwithUTF8ViewIt works today except for if the pattern was
Utf8Viewbut that turns out to be an over eager error in the planner -- the kernels work just fineWhat changes are included in this PR?
LIKE/ILIKEwork withUtf8View(andLargeUtf8andDictionary)Are these changes tested?
Yes
Are there any user-facing changes?
You can now run
... LIKE <Utf8View>column