Add support for Utf8View to crypto functions #13407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
🚀 |
This was referenced Nov 15, 2024
|
I tried to write some more tests for this code and I think it may have introduced a bug. See |
|
I'll take a look at this tonight if no one else beats me to it
…On Fri, Nov 15, 2024, 2:50 p.m. Andrew Lamb ***@***.***> wrote:
I tried to write some more tests for this code and I think it may have
introduced a bug. See
- in #13443 <#13443>
- #13444 <#13444>
—
Reply to this email directly, view it on GitHub
<#13407 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXHUQMSQVHLAMXBSMYSZ32AZGB3AVCNFSM6AAAAABRX3SQFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZZHAYTENBWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13406
Rationale for this change
Completing support for utf8view in functions.
What changes are included in this PR?
Code, tests.
Are these changes tested?
Yes
Are there any user-facing changes?
No