docs: Improve user documentation for supported operators and expressions #520
Conversation
|
I plan on keeping this as draft for a while and will keep updating it as we prepare for the 0.1.0 release. |
| @@ -563,7 +563,7 @@ impl PhysicalPlanner { | |||
| let child = self.create_expr(expr.child.as_ref().unwrap(), input_schema)?; | |||
| Ok(Arc::new(NotExpr::new(child))) | |||
| } | |||
| ExprStruct::Negative(expr) => { | |||
There was a problem hiding this comment.
I renamed this because it was inconsistent with Spark naming
|
@parthchandra @kazuyukitanimura @huaxingao @viirya This is ready for review now. Thanks. |
|
@comphead This is the user guide version of the list of supported expressions with notes about known issues. I think this is separate from the list that you are generating for the contributors guide. |
docs/source/user-guide/operators.md
Outdated
| | Sort | | | ||
| | Hash Aggregate | | | ||
| | Limit | | | ||
| | Sort-merge Join | Sort-merge join is disabled by default | |
There was a problem hiding this comment.
oh, is SMJ disabled by default?
There was a problem hiding this comment.
It looks like I misunderstood this. I have update this.
Co-authored-by: Liang-Chi Hsieh <[email protected]>
Co-authored-by: Liang-Chi Hsieh <[email protected]>
| | Repeat | Negative argument for number of times to repeat causes exception | | ||
| | Replace | | | ||
| | Reverse | | | ||
| | RLike | Disabled by default. Uses Rust regular expression engine which is not compatible with Java's regexp engine. | |
There was a problem hiding this comment.
nit: RLike is still under review. Not sure which gets merged first...
There was a problem hiding this comment.
I have removed this and will add it back in the RLike PR after this one is merged
…ons (apache#520) * Improve documentation about supported operators and expressions * Improve documentation about supported operators and expressions * more notes * Add more supported expressions * rename protobuf Negative to UnaryMinus for consistency * format * remove duplicate ASF header * SMJ not disabled by default * Update docs/source/user-guide/operators.md Co-authored-by: Liang-Chi Hsieh <[email protected]> * Update docs/source/user-guide/operators.md Co-authored-by: Liang-Chi Hsieh <[email protected]> * remove RLike --------- Co-authored-by: Liang-Chi Hsieh <[email protected]>
Which issue does this PR close?
N/A
Rationale for this change
The list of supported expressions was incomplete and we did provide any information about known incompatibilities
What changes are included in this PR?
NegativetoUnaryMinusin protobuf for consistencyHow are these changes tested?