chore: Update README to highlight Comet benefits #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
May 31, 2024
comphead
reviewed
May 31, 2024
|
|
||
| <a href="docs/source/_static/images/comet-overview.png"><img src="docs/source/_static/images/comet-overview.png" align="center" height="600" width="750" ></a> | ||
| Comet is not yet achieving full DataFusion speeds in all cases, but with future work we aim to provide a 2x-4x speedup |
There was a problem hiding this comment.
if pure DF gives 3.9x, is that possible Comet built on top of DF to give 4x?
There was a problem hiding this comment.
I was rounding up to the nearest whole percent here, but of course it will be challenging. DataFusion isn't performing shuffle operations, but I think that DataFusion performance sets a hard limit on what we can do with Comet, so 2-4x seems to be our expected range (unless there are future optimizations in DataFusion).
comphead
reviewed
May 31, 2024
Co-authored-by: Oleks V <[email protected]>
kazuyukitanimura
approved these changes
May 31, 2024
|
Thanks for the reviews @viirya @kazuyukitanimura @comphead. I have addressed the feedback so will go ahead and merge this and we can follow up with future PRs if we want to refine this more. |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* Update README to show current performance info * Update README.md Co-authored-by: Oleks V <[email protected]> * address feedback * Add hardware info to benchmarking page * add raw benchmark results --------- Co-authored-by: Oleks V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
By focusing on the benefits of Comet, and showing some performance results, we can hopefully make the project more compelling to users who may consider trying it out.
What changes are included in this PR?
New README. You can see the rendered version here
How are these changes tested?