Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend FileReader to conform with EventTarget interface #449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BendingBender
Copy link

@BendingBender BendingBender commented Dec 23, 2020

Platforms affected

All.

Motivation and Context

Currently, cordova-plugin-file's FileReader doesn't correctly implement the EventTarget interface. What works are listeners attached via on[event] properties, like onloadend. What doesn't work are listeners attached via addEventListener('loadend', ...), they are simply never called.

Some libraries depend upon FileReader to implement the EventTarget interface. One such library is the Elm File package, it attaches events to FileReader via addEventListener('loadend', ...) (see https://github.com/elm/file/blob/1.0.5/src/Elm/Kernel/File.js#L155).

Description

The implmentations of FileReader was changed so that events attached via EventTarget's addEventListener() method are called just like the listeners attached via on[event] properties.

Testing

This change has been in our Cordova app in production for a while, without negative effects.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@danilobassi8
Copy link

Hi, does this fix issues like #544 ??

@BendingBender
Copy link
Author

I don't know but you're free to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants