-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dep!: April 2024 update #270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- karma@^6.4.3 - karma-chrome-launcher@^3.2.0 - karma-coverage@^2.2.1
- grunt@^1.6.1 - grunt-contrib-clean@^2.0.1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
=======================================
Coverage 83.62% 83.62%
=======================================
Files 14 14
Lines 519 519
=======================================
Hits 434 434
Misses 85 85 ☔ View full report in Codecov by Sentry. |
This was referenced Apr 10, 2024
dpogue
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
n/a
Motivation and Context
Update CI & NPM dependencies &
package-lock.json
Description
NPM dependencies:
globby@^11.1.0
grunt@^1.6.1
grunt-contrib-clean@^2.0.1
jasmine-core@^5.1.2
karma@^6.4.3
karma-chrome-launcher@^3.2.0
karma-coverage@^2.2.1
puppeteer@^22.6.3
@cordova/eslint-config@^5.1.0
NPM package chores:
package-lock.json
package-lock.json
CI dependencies:
actions/checkout@v4
actions/setup-node@v4
codecov/codecov-action@v4
w/ token entryThis PR will not cover upgrading the following packages and will be handled in a separate PR:
The above packages will need to be fetched with git and not npm. The npm packages, even if pointing to the git repo, does not come with the files that are needed for testing.
Testing
npm t
npm run build
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)