Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: eslint setup #221

Merged
merged 2 commits into from
Nov 27, 2019
Merged

refactor: eslint setup #221

merged 2 commits into from
Nov 27, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 27, 2019

Motivation and Context

Description

  • replace dependencies with @cordova/eslint-config
  • update eslint config
  • eslint corrections

Testing

  • npm t
  • npm run lint

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone Nov 27, 2019
@erisu erisu requested a review from raphinesse November 27, 2019 03:19
raphinesse
raphinesse approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some changes. LGTM now 👍

@erisu erisu merged commit 17ed8ef into apache:master Nov 27, 2019
@erisu erisu deleted the v6-eslint branch November 27, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphinesse raphinesse raphinesse approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @raphinesse