Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CDVWebViewEngine): use NSURL absoluteString value for stringWithFormat #1353

Closed

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 27, 2023

Motivation and Context

Description

Use NSURL absolute string value when used with stringWithFormat.

Testing

  • npm t
  • Standard Cordova Project Build Test

Does not cover embedded

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #1353 (a0b29c9) into master (6db1b6e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1353   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files          15       15           
  Lines        1773     1773           
=======================================
  Hits         1394     1394           
  Misses        379      379           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu erisu modified the milestone: 7.0.0 Jun 27, 2023
@erisu erisu closed this Sep 13, 2023
@erisu erisu deleted the fix/custom-scheme-embedded-webview branch September 13, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants