-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support finding an unprefixed Info.plist file #212
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 88.40% 88.70% +0.30%
==========================================
Files 20 20
Lines 1147 1160 +13
==========================================
+ Hits 1014 1029 +15
+ Misses 133 131 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This will also allow us to drop the read-chunk dependency.
Co-Authored-By: Norman Breau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
Platforms affected
iOS
Motivation and Context
Currently the Info.plist file in a generated iOS project is prefixed with the project name (i.e.,
HelloCordova-Info.plist
), and plugins have to set up theirconfig-file
/edit-config
directives to use wildcards like**/*-Info.plist
.The standard way for Xcode projects is to just have
Info.plist
in the project, and this gets us one step closer to supporting that.Description
Testing
Added a new test for the Info.plist behaviour. All existing tests pass.
Checklist