New method ConfigParser.getByName to find a resource containig a stri… #13
Conversation
…ng in its src. Needed to fix cordova-ios, which is erroneously using getBySize when more than one resource have the same dimensions.
…ng in its src. Needed to fix cordova-ios, which is erroneously using getBySize when more than one resource have the same dimensions.
|
Where and why would this method be useful? |
There was a problem hiding this comment.
We need an answer to the question by @janpio before we consider merging this one:
Where and why would this method be useful?
I would favor closing this PR if we do not get this question answered soon. I left a review to avoid a premature merge. |
|
I added it while I was using [email protected] (which I still use a fork of) because getting resource by size is ambiguous: [email protected] has the same size of [email protected]. The [email protected] was missing in my builds because of the mapIconResources method in prepare.js file which defines two resources with same size. I forked cordova-ios and changed prepare.js removing the resources for apple watch, but it would be more correct to be able to look for a resource by name. The current prepare.js still has the issue |
There was a problem hiding this comment.
Ok, so this is preparatory work for an incoming cordova-ios PR that could fix an issue with it, correct? If so, please make sure that an issue for cordova-ios about this problem you described exists (and links to this PR as a precondition) so we don't forget to actually implement this ;)
…ng in its src.
Needed to fix cordova-ios, which is erroneously using getBySize when more than one resource have the same dimensions.