pg_upgrade: Resolve FIXMEs in pg_upgrade.c and info.c

prepare_new_globals() was introduced in b3f8401
which moves handling of database properties from pg_dumpall to pg_dump.

pg_dump handles all properties attached to a single database while
pg_dumpall --globals-only --resource-groups --resource-queues will
dump role, tablespace, resource group, and resource queue related
output.

Restoring the databases is now handled in create_new_objects.

is_appendonly() can be used to determine if a relation is AO.

Authored-by: Brent Doil <[email protected]>

src/bin/pg_upgrade/info.c

@@ -238,10 +238,8 @@ create_rel_filename_map(const char *old_data, const char *new_data,
 	map->natts = old_rel->natts;
 	map->type = old_rel->reltype;
 
-#if 0 /* GPDB_12_MERGE_FIXME - replace relstorage check which was removed */
 	/* An AO table doesn't necessarily have segment 0 at all. */
-	map->missing_seg0_ok = relstorage_is_ao(old_rel->relstorage);
-#endif
+	map->missing_seg0_ok = is_appendonly(old_rel->relstorage);
 
 	/* used only for logging and error reporting, old/new are identical */
 	map->nspname = old_rel->nspname;

src/bin/pg_upgrade/pg_upgrade.c

@@ -210,11 +210,6 @@ main(int argc, char **argv)
 
 	if (is_greenplum_dispatcher_mode())
 	{
-		/*
-		 * GPDB_12_MERGE_FIXME: this is where we used to create new databases
-		 * in case we were the dispatcher, now upstream does prepare_new_globals.
-		 * Verify that this replacement is what we want.
-		 */
 		prepare_new_globals();
 
 		create_new_objects();