issue-1774: Method to retrieve info about client connections was added #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testisnullus
force-pushed
the
issue-1774
branch
from
af5fe82
to
ccf3387
Compare
testisnullus
changed the title
worryg0d
reviewed
Aug 13, 2024
session.go
Outdated
| // scans the results into a slice of `ClientConnection` structs. It handles nullable | ||
| // fields and returns the list of connections or an error if the operation fails. | ||
| func (s *Session) RetrieveClientConnections(connectionType connectionType) ([]*ClientConnection, error) { | ||
| query := "SELECT address, port, connection_stage, driver_name, driver_version, hostname, keyspace_name, protocol_version, request_count, ssl_cipher_suite, ssl_enabled, ssl_protocol, username FROM system_views.clients WHERE connection_stage = ?" |
There was a problem hiding this comment.
I think we should follow the general pattern of code styling for similar methods that are used for querying some system/system_views tables. So you should define this query as a string const and use idents as well. You may find some examples in the Session.KeyspaceMetadata() method
session.go
Outdated
Comment on lines
799
to
833
| type ClientConnection struct { | ||
| Address string `json:"address"` | ||
| Port int `json:"port"` | ||
| ConnectionStage string `json:"connection_stage"` | ||
| DriverName string `json:"driver_name"` | ||
| DriverVersion string `json:"driver_version"` | ||
| Hostname string `json:"hostname"` | ||
| KeyspaceName *string `json:"keyspace_name"` | ||
| ProtocolVersion int `json:"protocol_version"` | ||
| RequestCount int `json:"request_count"` | ||
| SSLCipherSuite *string `json:"ssl_cipher_suite"` | ||
| SSLEnabled bool `json:"ssl_enabled"` | ||
| SSLProtocol *string `json:"ssl_protocol"` | ||
| Username string `json:"username"` | ||
| } |
There was a problem hiding this comment.
Are these json tags really necessary?
testisnullus
force-pushed
the
issue-1774
branch
from
ccf3387
to
ae96fac
Compare
worryg0d
approved these changes
Aug 13, 2024
worryg0d
reviewed
Aug 14, 2024
session.go
Outdated
|
|
||
| iter := s.control.query(stmt, connectionType) | ||
| if iter.NumRows() == 0 { | ||
| return nil, ErrKeyspaceDoesNotExist |
There was a problem hiding this comment.
Oops, I missed this before. I think you should return an error related to connectionType, not keyspace
testisnullus
force-pushed
the
issue-1774
branch
from
ae96fac
to
ef8de83
Compare
RostislavPorohnya
approved these changes
Aug 14, 2024
testisnullus
force-pushed
the
issue-1774
branch
from
fd7b28a
to
b2e98d5
Compare
testisnullus
force-pushed
the
issue-1774
branch
from
b2e98d5
to
aa8e727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR a new custom type
connectionTypewas added to categorize different stages of client connections within a Cassandra cluster. Additionally, theClientConnectionstruct was introduced to encapsulate detailed information about each connection, such as client address, connection stage, driver details, and SSL configuration. A new method,RetrieveClientConnections, was implemented to retrieve client connections based on their connection stage from the system_views.clients table.